bump_version_update_changelog_create_pr_action and create_next_snapshot_version_action: added next_release label
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Aug 9, 2022
This was referenced Aug 9, 2022
|
@tonidero this looks good to you too? |
vegaro
reviewed
Aug 10, 2022
lib/fastlane/plugin/revenuecat_internal/actions/create_next_snapshot_version_action.rb
Outdated
Show resolved
Hide resolved
...astlane/plugin/revenuecat_internal/actions/bump_version_update_changelog_create_pr_action.rb
Outdated
Show resolved
Hide resolved
tonidero
reviewed
Aug 10, 2022
lib/fastlane/plugin/revenuecat_internal/helper/revenuecat_internal_helper.rb
Show resolved
Hide resolved
lib/fastlane/plugin/revenuecat_internal/helper/revenuecat_internal_helper.rb
Outdated
Show resolved
Hide resolved
|
One question, if the label doesn't exist, does it create it? Just wondering since this will be used in other repos as well. |
NachoSoto
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Aug 12, 2022
NachoSoto
commented
Aug 12, 2022
lib/fastlane/plugin/revenuecat_internal/helper/revenuecat_internal_helper.rb
Outdated
Show resolved
Hide resolved
…pshot_version_action`: added `next_release` label This will prevent Danger from failing these PRs due to missing a change label.
NachoSoto
force-pushed
the
release-prs-labels
branch
from
92e2071
to
3572b32
Compare
|
This is ready again |
I don't think so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent Danger from failing these PRs due to missing a change label.
See also RevenueCat/purchases-ios#1810